[
https://issues.apache.org/jira/browse/BEAM-4073?focusedWorklogId=98617&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98617
]
ASF GitHub Bot logged work on BEAM-4073:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 22:38
Start Date: 04/May/18 22:38
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5270:
[BEAM-4073] Migrate the `portable` subpackage to use Portable representations
URL: https://github.com/apache/beam/pull/5270#discussion_r186236647
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/GroupAlsoByWindowEvaluatorFactory.java
##########
@@ -138,30 +126,30 @@ public GroupAlsoByWindowEvaluator(
.getExecutionContext(application, inputBundle.getKey())
.getStepContext(
evaluationContext.getStepName(application));
+ // TODO: extract from input PCollection via the graph, including
length-prefixing
windowingStrategy =
- (WindowingStrategy<?, BoundedWindow>)
- application.getTransform().getInputWindowingStrategy();
+ null;
outputBundles = new ArrayList<>();
unprocessedElements = ImmutableList.builder();
+ // TODO: extract from input PCollection via the graph, including
length-prefixing
Review comment:
I would expect that these elements would have gone through the shared code
with Flink/... to perform these conversions and wouldn't be specialized inside
of the direct runner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98617)
Time Spent: 2h (was: 1h 50m)
> The DirectRunner should interact with a Pipeline via an abstraction of the
> Graph rather than SDK types
> ------------------------------------------------------------------------------------------------------
>
> Key: BEAM-4073
> URL: https://issues.apache.org/jira/browse/BEAM-4073
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
