[
https://issues.apache.org/jira/browse/BEAM-4073?focusedWorklogId=98639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98639
]
ASF GitHub Bot logged work on BEAM-4073:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 23:54
Start Date: 04/May/18 23:54
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #5270:
[BEAM-4073] Migrate the `portable` subpackage to use Portable representations
URL: https://github.com/apache/beam/pull/5270#discussion_r186244402
##########
File path:
runners/direct-java/src/test/java/org/apache/beam/runners/direct/portable/FlattenEvaluatorFactoryTest.java
##########
@@ -49,30 +47,44 @@
@Rule public TestPipeline p =
TestPipeline.create().enableAbandonedNodeEnforcement(false);
+ @Ignore("Enable when the Flatten Evaluator Factory is fully migrated")
@Test
public void testFlattenInMemoryEvaluator() throws Exception {
- PCollection<Integer> left = p.apply("left", Create.of(1, 2, 4));
- PCollection<Integer> right = p.apply("right", Create.of(-1, 2, -4));
- PCollectionList<Integer> list = PCollectionList.of(left).and(right);
-
- PCollection<Integer> flattened = list.apply(Flatten.pCollections());
-
- CommittedBundle<Integer> leftBundle =
bundleFactory.createBundle(left).commit(Instant.now());
- CommittedBundle<Integer> rightBundle =
bundleFactory.createBundle(right).commit(Instant.now());
+ PCollectionNode left =
Review comment:
It doesn't work in this context, because I haven't added joins (and I'd
probably like to avoid to for the time being)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98639)
Time Spent: 3h 20m (was: 3h 10m)
> The DirectRunner should interact with a Pipeline via an abstraction of the
> Graph rather than SDK types
> ------------------------------------------------------------------------------------------------------
>
> Key: BEAM-4073
> URL: https://issues.apache.org/jira/browse/BEAM-4073
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
