[ 
https://issues.apache.org/jira/browse/BEAM-4073?focusedWorklogId=98643&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98643
 ]

ASF GitHub Bot logged work on BEAM-4073:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/May/18 23:54
            Start Date: 04/May/18 23:54
    Worklog Time Spent: 10m 
      Work Description: tgroh commented on a change in pull request #5270: 
[BEAM-4073] Migrate the `portable` subpackage to use Portable representations
URL: https://github.com/apache/beam/pull/5270#discussion_r186244289
 
 

 ##########
 File path: 
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/QuiescenceDriver.java
 ##########
 @@ -154,19 +155,17 @@ private void applyUpdate(
   /** Fires any available timers. */
   private void fireTimers() {
     try {
-      for (FiredTimers<AppliedPTransform<?, ?, ?>> transformTimers :
-          evaluationContext.extractFiredTimers()) {
+      for (FiredTimers<PTransformNode> transformTimers : 
evaluationContext.extractFiredTimers()) {
+        checkState(false, "fireTimers not yet supported");
 
 Review comment:
   Done. This will actually break earlier, but there are no users so that's 
fine until it's fully implemented.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 98643)
    Time Spent: 3h 40m  (was: 3.5h)

> The DirectRunner should interact with a Pipeline via an abstraction of the 
> Graph rather than SDK types
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-4073
>                 URL: https://issues.apache.org/jira/browse/BEAM-4073
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>            Priority: Major
>              Labels: portability
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to