[
https://issues.apache.org/jira/browse/BEAM-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467427#comment-16467427
]
Cao Manh Dat commented on BEAM-3947:
------------------------------------
After putting a lot of thought on this issue. I think the best strategy is Beam
should support as many version of Solr as possible (5.x, 6.x 7.x). But the
problems arise on how we can test it? In SolrIOTest.java we can only test one
version of Solr (currently Solr 5) because the cluster started on the test is
in the same JVM as the SolrIO.
We can not use the same strategy as ElasticsearchIO, because nodes of
elasticsearch use org.elasticsearch.client.transport to communicate and
elasticsearchio use org.elasticsearch.client.restclient to communicate to
elasticsearch nodes
but in Solr, nodes also use solrj to communicate, therefore if we spin up a
cluster of Solr 6 in SolrIOTest, the solrj version in classpath will be solrj 6.
the only option we have left is testing different Solr's versions verions using
docker (SolrITTest)
therefore the test (SolrIO) will run on different JVM as Solr nodes (just like
in production world)
Note that: The rule of Lucene/Solr is any methods can be removed after 2 major
version (ie: methods of Solr 5 can be removed in Solr 7).
> Add support for Solr 6.x/7.x
> ----------------------------
>
> Key: BEAM-3947
> URL: https://issues.apache.org/jira/browse/BEAM-3947
> Project: Beam
> Issue Type: Improvement
> Components: io-java-solr
> Reporter: Ismaël Mejía
> Assignee: Cao Manh Dat
> Priority: Minor
>
> The initial PR on Solr was based on Solr 6.x, however at that time we
> supported Java 7 so Insisted to move it to Solr 5.x (which is Java 7
> compatible). This issue is to add support for multiple versions of Solr
> ideally in a single module.
> Notice that I was able to recover the original code for Solr 6.x created by
> [~caomanhdat] here (there are some differences in the way the Split was
> calculated and maybe some other minor things):(
> [https://github.com/iemejia/beam/blob/recover-solrio/sdks/java/io/solr/pom.xml]
> This issue does not cover support for Solr 7, but if it is possible to add it
> as part of it, it would be great.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
