[
https://issues.apache.org/jira/browse/BEAM-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467444#comment-16467444
]
Tim Robertson commented on BEAM-3947:
-------------------------------------
[~caomanhdat] I am probably overlooking something simple but doesn't
elasticsearch-tests have a separate module per version which only really differ
in the test scope dependencies?
https://github.com/apache/beam/tree/master/sdks/java/io/elasticsearch-tests
Isn't the problem not the tests but that we (may) need different builds of the
SolrIO to support API changes across versions of the SolrJ dependency? I gather
that is a viable option for IO design when necessary.
> Add support for Solr 6.x/7.x
> ----------------------------
>
> Key: BEAM-3947
> URL: https://issues.apache.org/jira/browse/BEAM-3947
> Project: Beam
> Issue Type: Improvement
> Components: io-java-solr
> Reporter: Ismaël Mejía
> Assignee: Cao Manh Dat
> Priority: Minor
>
> The initial PR on Solr was based on Solr 6.x, however at that time we
> supported Java 7 so Insisted to move it to Solr 5.x (which is Java 7
> compatible). This issue is to add support for multiple versions of Solr
> ideally in a single module.
> Notice that I was able to recover the original code for Solr 6.x created by
> [~caomanhdat] here (there are some differences in the way the Split was
> calculated and maybe some other minor things):(
> [https://github.com/iemejia/beam/blob/recover-solrio/sdks/java/io/solr/pom.xml]
> This issue does not cover support for Solr 7, but if it is possible to add it
> as part of it, it would be great.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
