[
https://issues.apache.org/jira/browse/BEAM-3883?focusedWorklogId=100807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-100807
]
ASF GitHub Bot logged work on BEAM-3883:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/18 20:19
Start Date: 10/May/18 20:19
Worklog Time Spent: 10m
Work Description: angoenka commented on issue #5251: [BEAM-3883] Refactor
and clean dependency.py to make it reusable with artifact service
URL: https://github.com/apache/beam/pull/5251#issuecomment-388173088
I agree with the general structure you mentioned. And just to rephrase it I
would call them
1. Collect artifacts
2. Commit artifacts
The key difference in the current code is that it commits individual
artifacts when it finds them while collecting. This certainly makes the code
messy.
However there are some challenges as how we download artifacts which can
depend upon the setup.
To reuse collection code we will need to pass a download_file method which
can download remote file to local file system from a variety of sources.
And then we will have a upload_file which will be used in commit artifacts.
Which brings us very close to the current implementation and make me less
inclined towards this change.
FileHandler has just 2 methods download_file and upload_file which clearly
outlined the the expectations from a runner. This makes stager completely
reusable with different FileHandlers.
Please let me know if it makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 100807)
Time Spent: 6h 50m (was: 6h 40m)
> Python SDK stages artifacts when talking to job server
> ------------------------------------------------------
>
> Key: BEAM-3883
> URL: https://issues.apache.org/jira/browse/BEAM-3883
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ben Sidhom
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> The Python SDK does not currently stage its user-defined functions or
> dependencies when talking to the job API. Artifacts that need to be staged
> include the user code itself, any SDK components not included in the
> container image, and the list of Python packages that must be installed at
> runtime.
>
> Artifacts that are currently expected can be found in the harness boot code:
> [https://github.com/apache/beam/blob/58e3b06bee7378d2d8db1c8dd534b415864f63e1/sdks/python/container/boot.go#L52.]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
