[
https://issues.apache.org/jira/browse/BEAM-3883?focusedWorklogId=101285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-101285
]
ASF GitHub Bot logged work on BEAM-3883:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/18 19:58
Start Date: 11/May/18 19:58
Worklog Time Spent: 10m
Work Description: angoenka commented on issue #5251: [BEAM-3883] Refactor
and clean dependency.py to make it reusable with artifact service
URL: https://github.com/apache/beam/pull/5251#issuecomment-388470371
From the perspective of fixing the entanglement in the code, I do not want
to handle it in this PR as it is unrelated to streamlining dependency.py. The
current entanglement is in the apiclient.py which does file staging and reuse
some of the same state. I think this should be handled separately as its not in
the scope of this PR.
Regarding the naming of GCSStager, its because its not intended to be used
outside apiclient and is only meant to be used for dataflow runner. I would be
happy to rename it as long as the name signifies that its not meant for use
elsewhere. I can also make it a private class if it makes sense.
"ParameterizedStager" seems to be a good name and just to make it private, I
will make it "_ParameterizedStager".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 101285)
Time Spent: 7h 20m (was: 7h 10m)
> Python SDK stages artifacts when talking to job server
> ------------------------------------------------------
>
> Key: BEAM-3883
> URL: https://issues.apache.org/jira/browse/BEAM-3883
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ben Sidhom
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> The Python SDK does not currently stage its user-defined functions or
> dependencies when talking to the job API. Artifacts that need to be staged
> include the user code itself, any SDK components not included in the
> container image, and the list of Python packages that must be installed at
> runtime.
>
> Artifacts that are currently expected can be found in the harness boot code:
> [https://github.com/apache/beam/blob/58e3b06bee7378d2d8db1c8dd534b415864f63e1/sdks/python/container/boot.go#L52.]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
