[ 
https://issues.apache.org/jira/browse/BEAM-4140?focusedWorklogId=102448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102448
 ]

ASF GitHub Bot logged work on BEAM-4140:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/May/18 11:36
            Start Date: 16/May/18 11:36
    Worklog Time Spent: 10m 
      Work Description: lgajowy commented on issue #5383: [BEAM-4140] Utilize 
beam_location perfkit flag
URL: https://github.com/apache/beam/pull/5383#issuecomment-389488014
 
 
   I run 2 performance tests in this PR and they worked without cloning twice.
   
   @jasonkuster @chamikaramj could you take a look? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 102448)
            Time Spent: 10m
    Remaining Estimate: 0h

> Beam repo is cloned 2 times instead of one during Performance test jenkins 
> Jobs
> -------------------------------------------------------------------------------
>
>                 Key: BEAM-4140
>                 URL: https://issues.apache.org/jira/browse/BEAM-4140
>             Project: Beam
>          Issue Type: Bug
>          Components: testing
>            Reporter: Łukasz Gajowy
>            Assignee: Łukasz Gajowy
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Example jenkins job logs can be found here (any job): 
> [https://builds.apache.org/view/A-D/view/Beam/job/beam_PerformanceTests_JDBC/]
>  . This is best visible if one searches logs by "git clone". 
> First clone is done by a jenkins job to a $WORKSPACE/src directory: 
> [https://github.com/apache/beam/blob/9c9f4ceceb87933da2b03304efd21edf55216937/.test-infra/jenkins/common_job_properties.groovy#L96]
> Second one is performed by Perfkit: 
> [https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/f852afab0f71489958240299706878c1e51f1e89/perfkitbenchmarker/beam_benchmark_helper.py#L141]
> This seems to be redundant. We either can utilize "beam_location" perfkit's 
> flag or not clone the repo to '$WORKSPACE/src' directory. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to