[
https://issues.apache.org/jira/browse/BEAM-4140?focusedWorklogId=102591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102591
]
ASF GitHub Bot logged work on BEAM-4140:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/18 18:33
Start Date: 16/May/18 18:33
Worklog Time Spent: 10m
Work Description: jasonkuster closed pull request #5383: [BEAM-4140]
Utilize beam_location perfkit flag
URL: https://github.com/apache/beam/pull/5383
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.test-infra/jenkins/common_job_properties.groovy
b/.test-infra/jenkins/common_job_properties.groovy
index 60493a14369..24921eb4b34 100644
--- a/.test-infra/jenkins/common_job_properties.groovy
+++ b/.test-infra/jenkins/common_job_properties.groovy
@@ -261,6 +261,8 @@ class common_job_properties {
maven_binary: '/home/jenkins/tools/maven/latest/bin/mvn',
bigquery_table: 'beam_performance.pkb_results',
temp_dir: '$WORKSPACE',
+ // Use source cloned by Jenkins and not clone it second time
(redundantly).
+ beam_location: '$WORKSPACE/src',
// Publishes results with official tag, for use in dashboards.
official: 'true'
]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 102591)
Time Spent: 1h 10m (was: 1h)
> Beam repo is cloned 2 times instead of one during Performance test jenkins
> Jobs
> -------------------------------------------------------------------------------
>
> Key: BEAM-4140
> URL: https://issues.apache.org/jira/browse/BEAM-4140
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Łukasz Gajowy
> Assignee: Łukasz Gajowy
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> +Proof:+
> Example Jenkins job logs can be found here (any job):
> [https://builds.apache.org/view/A-D/view/Beam/job/beam_PerformanceTests_JDBC/]
> . This is best visible if one searches logs by "git clone".
> First, cloning is done by a Jenkins job to a $WORKSPACE/src directory:
> [https://github.com/apache/beam/blob/9c9f4ceceb87933da2b03304efd21edf55216937/.test-infra/jenkins/common_job_properties.groovy#L96]
> The second one is performed by Perfkit:
> [https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/f852afab0f71489958240299706878c1e51f1e89/perfkitbenchmarker/beam_benchmark_helper.py#L141]
> +Reasons I think this should be changed:+
> 1. This seems to be redundant. We either can utilize "beam_location"
> Perfkit's flag or not clone the repo to '$WORKSPACE/src' directory.
> 2. By cloning inside Perfkit we use the master branch. This is misguiding
> when developers want to test their Pull Requests in terms of performance
> (this is possible thanks to current Jenkins job configuration).
> 3. This also makes running on PR useless when developers add new code. It's
> not on master so Perfkit won't be able to pull it.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
