[
https://issues.apache.org/jira/browse/BEAM-4258?focusedWorklogId=102624&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102624
]
ASF GitHub Bot logged work on BEAM-4258:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/18 19:41
Start Date: 16/May/18 19:41
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5386:
[BEAM-4258] Add a new DockerEnvironmentFactory Constructor
URL: https://github.com/apache/beam/pull/5386#discussion_r188747620
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerEnvironmentFactory.java
##########
@@ -44,15 +45,35 @@
private static final Logger LOG =
LoggerFactory.getLogger(DockerEnvironmentFactory.class);
+ /**
+ * Returns a {@link DockerEnvironmentFactory} for the provided {@link
GrpcFnServer servers} using
+ * the default {@link DockerCommand} and {@link IdGenerators}.
+ */
public static DockerEnvironmentFactory forServices(
+ GrpcFnServer<FnApiControlClientPoolService> controlServiceServer,
+ GrpcFnServer<GrpcLoggingService> loggingServiceServer,
+ GrpcFnServer<ArtifactRetrievalService> retrievalServiceServer,
+ GrpcFnServer<StaticGrpcProvisionService> provisioningServiceServer,
+ ControlClientPool.Source clientSource) {
+ return forServicesWithDocker(
+ DockerCommand.getDefault(),
+ controlServiceServer,
+ loggingServiceServer,
+ retrievalServiceServer,
+ provisioningServiceServer,
+ clientSource,
+ IdGenerators.incrementingLongs());
+ }
+
+ static DockerEnvironmentFactory forServicesWithDocker(
DockerCommand docker,
GrpcFnServer<FnApiControlClientPoolService> controlServiceServer,
GrpcFnServer<GrpcLoggingService> loggingServiceServer,
GrpcFnServer<ArtifactRetrievalService> retrievalServiceServer,
GrpcFnServer<StaticGrpcProvisionService> provisioningServiceServer,
ControlClientPool.Source clientSource,
// TODO: Refine this to IdGenerator when we determine where that should
live.
Review comment:
Remove the outdated comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 102624)
Time Spent: 10m
Remaining Estimate: 0h
> Integrate Docker Environment Management in the ReferenceRunner
> --------------------------------------------------------------
>
> Key: BEAM-4258
> URL: https://issues.apache.org/jira/browse/BEAM-4258
> Project: Beam
> Issue Type: New Feature
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
