[
https://issues.apache.org/jira/browse/BEAM-4258?focusedWorklogId=102999&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102999
]
ASF GitHub Bot logged work on BEAM-4258:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/18 17:17
Start Date: 17/May/18 17:17
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5386:
[BEAM-4258] Add a new DockerEnvironmentFactory Constructor
URL: https://github.com/apache/beam/pull/5386#discussion_r189036171
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerCommand.java
##########
@@ -36,10 +36,16 @@
/** A docker command wrapper. Simplifies communications with the Docker
daemon. */
class DockerCommand {
+
+ private static final String DEFAULT_DOCKER_COMMAND = "docker";
// TODO: Should we require 64-character container ids? Docker technically
allows abbreviated ids,
// but we _should_ always capture full ids.
private static final Pattern CONTAINER_ID_PATTERN =
Pattern.compile("\\p{XDigit}{64}");
+ public static DockerCommand getDefault() {
Review comment:
Just a small note: there's not much point making this public since the class
is package-private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 102999)
Time Spent: 1h 10m (was: 1h)
> Integrate Docker Environment Management in the ReferenceRunner
> --------------------------------------------------------------
>
> Key: BEAM-4258
> URL: https://issues.apache.org/jira/browse/BEAM-4258
> Project: Beam
> Issue Type: New Feature
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
