[
https://issues.apache.org/jira/browse/BEAM-4300?focusedWorklogId=102643&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102643
]
ASF GitHub Bot logged work on BEAM-4300:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/18 20:37
Start Date: 16/May/18 20:37
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #5372:
[BEAM-4300] Fix ValidatesRunner tests in Python: run with same mechanism as ITs
URL: https://github.com/apache/beam/pull/5372#discussion_r188764406
##########
File path: sdks/python/run_postcommit.sh
##########
@@ -40,11 +39,15 @@ python setup.py sdist
SDK_LOCATION=$(find dist/apache-beam-*.tar.gz)
+# Install test dependencies for ValidatesRunner tests.
+echo "pyhamcrest" > postcommit_requirements.txt
+echo "mock" >> postcommit_requirements.txt
+
# Run integration tests on the Google Cloud Dataflow service
# and validate that jobs finish successfully.
echo ">>> RUNNING TEST DATAFLOW RUNNER it tests"
python setup.py nosetests \
- --attr IT \
+ --attr $1 \
Review comment:
Done. Also added the ability to receive GCP project / path parameters to run
tests locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 102643)
Time Spent: 20m (was: 10m)
> Duplicated code for ValidatesRunner / PostCommit tests in Python
> ----------------------------------------------------------------
>
> Key: BEAM-4300
> URL: https://issues.apache.org/jira/browse/BEAM-4300
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
