[
https://issues.apache.org/jira/browse/BEAM-4300?focusedWorklogId=102684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102684
]
ASF GitHub Bot logged work on BEAM-4300:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/18 22:10
Start Date: 16/May/18 22:10
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #5372:
[BEAM-4300] Fix ValidatesRunner tests in Python: run with same mechanism as ITs
URL: https://github.com/apache/beam/pull/5372#discussion_r188787607
##########
File path: sdks/python/run_postcommit.sh
##########
@@ -22,17 +22,24 @@
# GCS_LOCATION -> Temporary location to use for service tests.
# PROJECT -> Project name to use for service jobs.
#
-# Execute from the root of the repository: sdks/python/run_postcommit.sh
+
+if [ -z "$1" ]; then
+ printf "Usage: \n$> ./run_postcommit.sh <test_type> [gcp_location]
[gcp_project]"
+ printf "\n\ttest_type: ValidatesRunner or IT"
+ printf "\n\tgcp_location: A gs:// path to stage artifacts and output results"
+ printf "\n\tgcp_project: A GCP project to run Dataflow pipelines\n"
+ exit 1
+fi
set -e
set -v
# Run tests on the service.
# Where to store integration test outputs.
-GCS_LOCATION=gs://temp-storage-for-end-to-end-tests
+GCS_LOCATION=${2:-gs://temp-storage-for-end-to-end-tests}
Review comment:
Awesome!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 102684)
Time Spent: 40m (was: 0.5h)
> Duplicated code for ValidatesRunner / PostCommit tests in Python
> ----------------------------------------------------------------
>
> Key: BEAM-4300
> URL: https://issues.apache.org/jira/browse/BEAM-4300
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
