[
https://issues.apache.org/jira/browse/BEAM-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478315#comment-16478315
]
Teng Peng commented on BEAM-4318:
---------------------------------
Thanks for the instruction. I have run ./gradlew :beam-runners-spark:assemble,
but I do not see any warnings.
Mac:Beam pt$ ./gradlew :beam-runners-spark:assemble
Parallel execution with configuration on demand is an incubating feature.
> Configure project :
Applying build_rules.gradle to beam
createPerformanceTestHarness with default configuration for project beam
Adding 47 .gitignore exclusions to Apache Rat
> Configure project :beam-sdks-java-core
Applying build_rules.gradle to beam-sdks-java-core
applyJavaNature with
[shadowClosure:org.codehaus.groovy.runtime.ComposedClosure@536a44fb] for
project beam-sdks-java-core
applyAvroNature with default configuration for project beam-sdks-java-core
> Configure project :beam-runners-spark
Applying build_rules.gradle to beam-runners-spark
applyJavaNature with [failOnWarning:true] for project beam-runners-spark
Generating :runQuickstartJavaSpark
> Configure project :beam-model-pipeline
Applying build_rules.gradle to beam-model-pipeline
applyJavaNature with [enableFindbugs:false, enableErrorProne:false] for project
beam-model-pipeline
applyGrpcNature with default configuration for project beam-model-pipeline
> Configure project :beam-runners-core-construction-java
Applying build_rules.gradle to beam-runners-core-construction-java
applyJavaNature with default configuration for project
beam-runners-core-construction-java
> Configure project :beam-runners-core-java
Applying build_rules.gradle to beam-runners-core-java
applyJavaNature with default configuration for project beam-runners-core-java
> Configure project :beam-sdks-java-io-kafka
Applying build_rules.gradle to beam-sdks-java-io-kafka
applyJavaNature with [enableFindbugs:false] for project beam-sdks-java-io-kafka
> Configure project :beam-model-job-management
Applying build_rules.gradle to beam-model-job-management
applyJavaNature with [enableFindbugs:false, enableErrorProne:false] for project
beam-model-job-management
applyGrpcNature with default configuration for project beam-model-job-management
> Configure project :beam-model-fn-execution
Applying build_rules.gradle to beam-model-fn-execution
applyJavaNature with [enableFindbugs:false, enableErrorProne:false] for project
beam-model-fn-execution
applyGrpcNature with default configuration for project beam-model-fn-execution
Deprecated Gradle features were used in this build, making it incompatible with
Gradle 5.0.
See
https://docs.gradle.org/4.7/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 3s
37 actionable tasks: 37 up-to-date
> Enforce ErrorProne analysis in Spark runner project
> ---------------------------------------------------
>
> Key: BEAM-4318
> URL: https://issues.apache.org/jira/browse/BEAM-4318
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Scott Wegner
> Priority: Minor
> Labels: errorprone, starter
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-runners-spark}}. Additional context discussed on the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-runners-spark:assemble}}
> # Fix each ErrorProne warning from the {{runners/spark}} project.
> # In {{runners/spark/build.gradle}}, add {{failOnWarning: true}} to the call
> the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
