Joe Peng commented on BEAM-4318:

Thank you for the explanation. Now I understand how to read gradle info and
handle the cache. I will follow the instruction, and see if I can fix other
similar JIRA tickets. Thanks.

On Thu, May 17, 2018 at 11:28 AM Scott Wegner (JIRA) <j...@apache.org>

发自移动版 Gmail

> Enforce ErrorProne analysis in Spark runner project
> ---------------------------------------------------
>                 Key: BEAM-4318
>                 URL: https://issues.apache.org/jira/browse/BEAM-4318
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-spark
>            Reporter: Scott Wegner
>            Priority: Minor
>              Labels: errorprone, starter
> Java ErrorProne static analysis was [recently 
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build 
> process, but only as warnings. ErrorProne errors are generally useful and 
> easy to fix. Some work was done to [make sdks-java-core 
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add 
> enforcement. This task is clean ErrorProne warnings and add enforcement in 
> {{beam-runners-spark}}. Additional context discussed on the [dev 
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution 
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development 
> environment.
> # Run the following command to compile and run ErrorProne analysis on the 
> project: {{./gradlew :beam-runners-spark:assemble}}
> # Fix each ErrorProne warning from the {{runners/spark}} project.
> # In {{runners/spark/build.gradle}}, add {{failOnWarning: true}} to the call 
> the {{applyJavaNature()}} 
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach 
> out|https://beam.apache.org/community/contact-us/] with questions or code 
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com

This message was sent by Atlassian JIRA

Reply via email to