ASF GitHub Bot logged work on BEAM-3256:

                Author: ASF GitHub Bot
            Created on: 17/May/18 22:08
            Start Date: 17/May/18 22:08
    Worklog Time Spent: 10m 
      Work Description: swegner commented on a change in pull request #5014: 
BEAM-3256 Add archetype testing/generation to existing GradleBuild Pr…
URL: https://github.com/apache/beam/pull/5014#discussion_r189115743

 File path: sdks/java/maven-archetypes/examples/build.gradle
 @@ -55,6 +55,17 @@ task generateSources(type: Exec) {
   commandLine './generate-sources.sh'
+// Add archetype testing/generation to existing GradleBuild PreCommit
+// https://issues.apache.org/jira/browse/BEAM-3256
+task archetypesTest(type: Exec) {
+  if (project.hasProperty("maven_home")) {
+    commandLine "${maven_home}/bin/mvn", 'clean', 'install'
+    environment "MAVEN_HOME", "${maven_home}"
+  } else {
+    commandLine 'mvn', 'clean', 'install'
 Review comment:
   I'm investigating some [pre-commit 
on this task. I don't see anywhere as part of the execution that actually 
installs dependent maven artifacts in the local maven repository.
   Is there anything to ensure that the maven command will only use artifacts 
generated as part of this build?
   /cc @yifanzou @lukecwik 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 103143)
    Time Spent: 2.5h  (was: 2h 20m)

> Add archetype testing/generation to existing GradleBuild PreCommit
> ------------------------------------------------------------------
>                 Key: BEAM-3256
>                 URL: https://issues.apache.org/jira/browse/BEAM-3256
>             Project: Beam
>          Issue Type: Sub-task
>          Components: build-system
>            Reporter: Luke Cwik
>            Assignee: yifan zou
>            Priority: Major
>             Fix For: 2.5.0
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
> This build currently is not exercising the archetype build and tests 
> https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_beam_PreCommit_Java_GradleBuild.groovy
> found here:
> https://github.com/apache/beam/tree/master/sdks/java/maven-archetypes

This message was sent by Atlassian JIRA

Reply via email to