[ 
https://issues.apache.org/jira/browse/BEAM-3256?focusedWorklogId=103160&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-103160
 ]

ASF GitHub Bot logged work on BEAM-3256:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/May/18 23:02
            Start Date: 17/May/18 23:02
    Worklog Time Spent: 10m 
      Work Description: pabloem closed pull request #5403: [BEAM-3256] Remove 
stale TODO comments for adding archetype to java precommit
URL: https://github.com/apache/beam/pull/5403
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/java/maven-archetypes/examples/build.gradle 
b/sdks/java/maven-archetypes/examples/build.gradle
index 79139c4725d..b0f2d2b5da6 100644
--- a/sdks/java/maven-archetypes/examples/build.gradle
+++ b/sdks/java/maven-archetypes/examples/build.gradle
@@ -61,8 +61,6 @@ task generateSources(type: Exec) {
   commandLine './generate-sources.sh'
 }
 
-// Add archetype testing/generation to existing GradleBuild PreCommit
-// https://issues.apache.org/jira/browse/BEAM-3256
 task generateAndBuildArchetypeTest(type: Exec) {
   if (project.hasProperty("maven_home")) {
     commandLine "${maven_home}/bin/mvn", 'clean', 'install'
diff --git a/sdks/java/maven-archetypes/starter/build.gradle 
b/sdks/java/maven-archetypes/starter/build.gradle
index 01d02861345..9c5e6aa0b20 100644
--- a/sdks/java/maven-archetypes/starter/build.gradle
+++ b/sdks/java/maven-archetypes/starter/build.gradle
@@ -23,8 +23,6 @@ description = "Apache Beam :: SDKs :: Java :: Maven 
Archetypes :: Starter"
 ext.summary = """A Maven archetype to create a simple starter pipeline to
 get started using the Apache Beam Java SDK."""
 
-// Add archetype testing/generation to existing GradleBuild PreCommit
-// https://issues.apache.org/jira/browse/BEAM-3256
 task generateAndBuildArchetypeTest(type: Exec) {
   if (project.hasProperty("maven_home")) {
     commandLine "${maven_home}/bin/mvn", 'clean', 'install'


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 103160)
    Time Spent: 2h 50m  (was: 2h 40m)

> Add archetype testing/generation to existing GradleBuild PreCommit
> ------------------------------------------------------------------
>
>                 Key: BEAM-3256
>                 URL: https://issues.apache.org/jira/browse/BEAM-3256
>             Project: Beam
>          Issue Type: Sub-task
>          Components: build-system
>            Reporter: Luke Cwik
>            Assignee: yifan zou
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> This build currently is not exercising the archetype build and tests 
> https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_beam_PreCommit_Java_GradleBuild.groovy
> found here:
> https://github.com/apache/beam/tree/master/sdks/java/maven-archetypes



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to