[
https://issues.apache.org/jira/browse/BEAM-4392?focusedWorklogId=105321&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105321
]
ASF GitHub Bot logged work on BEAM-4392:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/18 21:00
Start Date: 23/May/18 21:00
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5457: [BEAM-4392] Fix
:beam-runners-java-fn-execution failure
URL: https://github.com/apache/beam/pull/5457#issuecomment-391494708
This passes with my tests in :beam-runners-java-fn-execution:test with
https://github.com/apache/beam/commit/c17332afef1ba5de86b021ab6af7054c33e0065b
There is a default rule to include all `compile` dependencies into the
shaded jar, which is what the `exclude(".*")` disables. Without that, the
`include` rules should be redundant. This increases the risk that we
accidentally ship things without relocating them. That is something we should
add tests for.
I have no opinion on which way is right, I'm learning gradle as I go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 105321)
Time Spent: 40m (was: 0.5h)
> Task :beam-runners-java-fn-execution:test gradle build failed
> -------------------------------------------------------------
>
> Key: BEAM-4392
> URL: https://issues.apache.org/jira/browse/BEAM-4392
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> build scan:
> https://www.google.com/url?q=https://scans.gradle.com/s/7ueucex6axz7g&sa=D&usg=AFQjCNGpWIafl8oZttFesg0MVWu7uA8Qmw
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
