[
https://issues.apache.org/jira/browse/BEAM-4392?focusedWorklogId=105379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105379
]
ASF GitHub Bot logged work on BEAM-4392:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/18 22:39
Start Date: 23/May/18 22:39
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5457:
[BEAM-4392] Fix :beam-runners-java-fn-execution failure
URL: https://github.com/apache/beam/pull/5457#discussion_r190420773
##########
File path: sdks/java/harness/build.gradle
##########
@@ -24,7 +24,16 @@ applyJavaNature(shadowClosure: DEFAULT_SHADOW_CLOSURE <<
// jars.
{
dependencies {
- include('**/*.class')
+ //Directly include all depended projects
+ include(project(":beam-model-pipeline"))
Review comment:
We want to use the shadow configuration so we'll need to specify these as
`path: projectName, configuration: "shadow"`
We should also use a list containing all the projects and loop over it here
and loop over it down below where we add the compile dependencies. This will
allow for a person to update the list in one location and have it apply to both
the shadow plugin and also the dependency set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 105379)
Time Spent: 1h 20m (was: 1h 10m)
> Task :beam-runners-java-fn-execution:test gradle build failed
> -------------------------------------------------------------
>
> Key: BEAM-4392
> URL: https://issues.apache.org/jira/browse/BEAM-4392
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> build scan:
> https://www.google.com/url?q=https://scans.gradle.com/s/7ueucex6axz7g&sa=D&usg=AFQjCNGpWIafl8oZttFesg0MVWu7uA8Qmw
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
