[
https://issues.apache.org/jira/browse/BEAM-4402?focusedWorklogId=105766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105766
]
ASF GitHub Bot logged work on BEAM-4402:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/18 22:42
Start Date: 24/May/18 22:42
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5471:
[BEAM-4402] Test shadowJar everywhere
URL: https://github.com/apache/beam/pull/5471#discussion_r190750951
##########
File path: build_rules.gradle
##########
@@ -621,6 +629,20 @@ artifactId=${project.name}
}
artifacts.archives javadocJar
+ // Run tests on artifacts
+ configurations {
+ shadowTestRuntimeClasspath
+ }
+
+ dependencies {
+ shadowTestRuntimeClasspath project(path: project.path, configuration:
"shadowTest")
+ shadowTestRuntimeClasspath project(path: project.path, configuration:
"provided")
Review comment:
There is also a `runtime` configuration that should be added to the
`shadowTestRuntimeClasspath`, similar to `provided`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 105766)
Time Spent: 40m (was: 0.5h)
> Run tests against shaded JAR
> ----------------------------
>
> Key: BEAM-4402
> URL: https://issues.apache.org/jira/browse/BEAM-4402
> Project: Beam
> Issue Type: New Feature
> Components: build-system
> Reporter: Andrew Pilloud
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We should run our tests against shaded jars.
> See https://github.com/apache/beam/pull/5471
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
