[
https://issues.apache.org/jira/browse/BEAM-4402?focusedWorklogId=107237&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107237
]
ASF GitHub Bot logged work on BEAM-4402:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/18 16:36
Start Date: 30/May/18 16:36
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5471:
[BEAM-4402] Test shadowJar everywhere
URL: https://github.com/apache/beam/pull/5471#discussion_r191836938
##########
File path:
runners/direct-java/src/test/java/org/apache/beam/runners/direct/DirectRunnerApiSurfaceTest.java
##########
@@ -73,7 +73,8 @@ public void testDirectRunnerApiSurface() throws Exception {
.pruningPattern("org[.]apache[.]beam[.].*IT")
.pruningPattern("java[.]io.*")
.pruningPattern("java[.]lang.*")
- .pruningPattern("java[.]util.*");
+ .pruningPattern("java[.]util.*")
+ .pruningPrefix("org.apache.beam.repackaged");
Review comment:
We shouldn't prune repackaged dependencies since this means that we will be
allowing things like repackaged guava as part of our dependency surface.
Add a JIRA + TODO about figuring out why we are exposing this. The
investigation should be a release blocker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 107237)
Time Spent: 1h 40m (was: 1.5h)
> Run tests against shaded JAR
> ----------------------------
>
> Key: BEAM-4402
> URL: https://issues.apache.org/jira/browse/BEAM-4402
> Project: Beam
> Issue Type: New Feature
> Components: build-system
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> We should run our tests against shaded jars.
> See https://github.com/apache/beam/pull/5471
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
