[
https://issues.apache.org/jira/browse/BEAM-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493478#comment-16493478
]
Ismaël Mejía commented on BEAM-4394:
------------------------------------
++1 on this one.
This is a detail that machines should do and also today we have common
conflicts because some devs formatting with the Beam Eclipse code style and
others with the google-java-format IntelliJ plugin. And both pass the
checkstyle plugin validation but with different output
Given the impact of this we should:
1. Define a strategy to autoformat all the code. Do we do it incrementally or
all in once?
2. Discuss this and if needed do a vote in the mailing list.
> Consider enabling spotless java format throughout codebase
> ----------------------------------------------------------
>
> Key: BEAM-4394
> URL: https://issues.apache.org/jira/browse/BEAM-4394
> Project: Beam
> Issue Type: New Feature
> Components: build-system
> Reporter: Kenneth Knowles
> Priority: Major
>
> "Spotless" can enforce - and automatically restore - automatic Java
> formatting. Whenever formatting is off, it tells a user the exact command to
> fix it.
> It isn't (just) about code layout, it is about automation. We have pretty
> strict style rules enforced by checkstyle. The most efficient way to fix up a
> file is with autoformat. But if the autoformat hits a bunch of irrelevant
> lines, that is annoying for a reviewer and obscures git blame.
> If we enforce autoformat all the time, then it makes sure that autoformatting
> a particular PR has minimal effects and is always safe to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
