[
https://issues.apache.org/jira/browse/BEAM-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496259#comment-16496259
]
Ismaël Mejía commented on BEAM-4394:
------------------------------------
I agree with good communication the impact is low and this is what is not
happening in this issue (and in the PR).
There are some issues:
- Other devs can disagree (which I doubt given the good arguments) but better
discuss than force things.
- It could break all other ongoing PRs (causing frustration to contributors).
- Contributors must be aware of this autoformat enforcing, this implies
updating the contribution guide + communicating in the ML.
About how to do it I don’t have a strict preference, I think the impact the
lowest impact is if it is done all at once. If you guys have someone who can do
it all at once e.g. in a day with low PR traffic, it is probably better, but
all people in the community deserve to be aware of this given that it impacts
their work.
> Consider enabling spotless java format throughout codebase
> ----------------------------------------------------------
>
> Key: BEAM-4394
> URL: https://issues.apache.org/jira/browse/BEAM-4394
> Project: Beam
> Issue Type: New Feature
> Components: build-system
> Reporter: Kenneth Knowles
> Priority: Major
>
> "Spotless" can enforce - and automatically restore - automatic Java
> formatting. Whenever formatting is off, it tells a user the exact command to
> fix it.
> It isn't (just) about code layout, it is about automation. We have pretty
> strict style rules enforced by checkstyle. The most efficient way to fix up a
> file is with autoformat. But if the autoformat hits a bunch of irrelevant
> lines, that is annoying for a reviewer and obscures git blame.
> If we enforce autoformat all the time, then it makes sure that autoformatting
> a particular PR has minimal effects and is always safe to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
