[
https://issues.apache.org/jira/browse/BEAM-4321?focusedWorklogId=106788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106788
]
ASF GitHub Bot logged work on BEAM-4321:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/18 19:54
Start Date: 29/May/18 19:54
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5500:
[BEAM-4321] Enforce ErrorProne analysis in join-library extensions
URL: https://github.com/apache/beam/pull/5500#discussion_r191552817
##########
File path: sdks/java/extensions/join-library/build.gradle
##########
@@ -17,14 +17,16 @@
*/
apply from: project(":").file("build_rules.gradle")
-applyJavaNature()
+applyJavaNature(failOnWarning: true)
description = "Apache Beam :: SDKs :: Java :: Extensions :: Join library"
dependencies {
compile library.java.guava
+ compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
testCompile project(path: ":beam-runners-direct-java", configuration:
"shadow")
testCompile library.java.hamcrest_core
testCompile library.java.junit
+ testCompileOnly library.java.findbugs_annotations
Review comment:
Yes is exactly as Tim says, it is the pattern we have followed so far in the
other IOs because fo complains in package-info and extra warnings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 106788)
Time Spent: 50m (was: 40m)
> Enforce ErrorProne analysis in join-library extensions project
> --------------------------------------------------------------
>
> Key: BEAM-4321
> URL: https://issues.apache.org/jira/browse/BEAM-4321
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-join-library
> Reporter: Scott Wegner
> Assignee: Ismaël Mejía
> Priority: Minor
> Labels: errorprone, starter
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-sdks-java-extensions-join-library}}. Additional context discussed on
> the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-sdks-java-extensions-join-library:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/extensions/join-library}}
> project.
> # In {{sdks/java/extensions/join-library/build.gradle}}, add {{failOnWarning:
> true}} to the call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
