[
https://issues.apache.org/jira/browse/BEAM-4321?focusedWorklogId=106858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106858
]
ASF GitHub Bot logged work on BEAM-4321:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/18 21:34
Start Date: 29/May/18 21:34
Worklog Time Spent: 10m
Work Description: iemejia closed pull request #5500: [BEAM-4321] Enforce
ErrorProne analysis in join-library extensions
URL: https://github.com/apache/beam/pull/5500
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/java/extensions/join-library/build.gradle
b/sdks/java/extensions/join-library/build.gradle
index c2327028420..fce523f8412 100644
--- a/sdks/java/extensions/join-library/build.gradle
+++ b/sdks/java/extensions/join-library/build.gradle
@@ -17,14 +17,16 @@
*/
apply from: project(":").file("build_rules.gradle")
-applyJavaNature()
+applyJavaNature(failOnWarning: true)
description = "Apache Beam :: SDKs :: Java :: Extensions :: Join library"
dependencies {
compile library.java.guava
+ compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
testCompile project(path: ":beam-runners-direct-java", configuration:
"shadow")
testCompile library.java.hamcrest_core
testCompile library.java.junit
+ testCompileOnly library.java.findbugs_annotations
}
diff --git
a/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/InnerJoinTest.java
b/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/InnerJoinTest.java
index 006f57c6031..385e2b693d7 100644
---
a/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/InnerJoinTest.java
+++
b/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/InnerJoinTest.java
@@ -35,10 +35,9 @@
* This test Inner Join functionality.
*/
public class InnerJoinTest {
-
- List<KV<String, Long>> leftListOfKv;
- List<KV<String, String>> listRightOfKv;
- List<KV<String, KV<Long, String>>> expectedResult;
+ private List<KV<String, Long>> leftListOfKv;
+ private List<KV<String, String>> listRightOfKv;
+ private List<KV<String, KV<Long, String>>> expectedResult;
@Rule
public final transient TestPipeline p = TestPipeline.create();
diff --git
a/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterFullJoinTest.java
b/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterFullJoinTest.java
index 3076f68558e..29d098a5c21 100644
---
a/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterFullJoinTest.java
+++
b/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterFullJoinTest.java
@@ -35,10 +35,9 @@
* This test Outer Full Join functionality.
*/
public class OuterFullJoinTest {
-
- List<KV<String, Long>> leftListOfKv;
- List<KV<String, String>> listRightOfKv;
- List<KV<String, KV<Long, String>>> expectedResult;
+ private List<KV<String, Long>> leftListOfKv;
+ private List<KV<String, String>> listRightOfKv;
+ private List<KV<String, KV<Long, String>>> expectedResult;
@Rule
public final transient TestPipeline p = TestPipeline.create();
diff --git
a/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterLeftJoinTest.java
b/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterLeftJoinTest.java
index 692f4710093..b7a1d1681b4 100644
---
a/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterLeftJoinTest.java
+++
b/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterLeftJoinTest.java
@@ -36,10 +36,9 @@
* This test Outer Left Join functionality.
*/
public class OuterLeftJoinTest {
-
- List<KV<String, Long>> leftListOfKv;
- List<KV<String, String>> listRightOfKv;
- List<KV<String, KV<Long, String>>> expectedResult;
+ private List<KV<String, Long>> leftListOfKv;
+ private List<KV<String, String>> listRightOfKv;
+ private List<KV<String, KV<Long, String>>> expectedResult;
@Rule
public final transient TestPipeline p = TestPipeline.create();
diff --git
a/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterRightJoinTest.java
b/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterRightJoinTest.java
index 4805a9b80c4..a4cd84156b0 100644
---
a/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterRightJoinTest.java
+++
b/sdks/java/extensions/join-library/src/test/java/org/apache/beam/sdk/extensions/joinlibrary/OuterRightJoinTest.java
@@ -36,10 +36,9 @@
* This test Outer Right Join functionality.
*/
public class OuterRightJoinTest {
-
- List<KV<String, Long>> leftListOfKv;
- List<KV<String, String>> listRightOfKv;
- List<KV<String, KV<Long, String>>> expectedResult;
+ private List<KV<String, Long>> leftListOfKv;
+ private List<KV<String, String>> listRightOfKv;
+ private List<KV<String, KV<Long, String>>> expectedResult;
@Rule
public final transient TestPipeline p = TestPipeline.create();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 106858)
Time Spent: 1h 20m (was: 1h 10m)
> Enforce ErrorProne analysis in join-library extensions project
> --------------------------------------------------------------
>
> Key: BEAM-4321
> URL: https://issues.apache.org/jira/browse/BEAM-4321
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-join-library
> Reporter: Scott Wegner
> Assignee: Ismaël Mejía
> Priority: Minor
> Labels: errorprone, starter
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-sdks-java-extensions-join-library}}. Additional context discussed on
> the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-sdks-java-extensions-join-library:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/extensions/join-library}}
> project.
> # In {{sdks/java/extensions/join-library/build.gradle}}, add {{failOnWarning:
> true}} to the call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
