[
https://issues.apache.org/jira/browse/BEAM-3773?focusedWorklogId=107205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107205
]
ASF GitHub Bot logged work on BEAM-3773:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/18 15:30
Start Date: 30/May/18 15:30
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5506:
[BEAM-3773] Build JDBC jar
URL: https://github.com/apache/beam/pull/5506#discussion_r191809531
##########
File path: sdks/java/extensions/sql/jdbc/build.gradle
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply from: project(":").file("build_rules.gradle")
Review comment:
You can do it all within one module but it isn't free since you'll need to
define multiple source sets, additional configurations, create all the tasks
needed for these additional source sets and configurations.
One of the things people forget that when you apply a Gradle plugin, is that
it sets up common configurations/tasks/.... Some of these plugins will use
other definitions within the project and will state something like will create
an X task for each Y definition (like the maven-publish plugin), these are good
since they scale well with more complex project configurations. Others just
setup a default set of tasks that are static (like the shadow plugin). (Note
that some plugin authors ship two versions of their plugin, a base version
which only adds the ability to use certain features/task definitions that the
plugin offers and a full plugin which includes the base and also sets up these
default tasks/configurations/...).
Having additional modules is much cheaper then having a really complicated
module and doesn't impose the same cost that Maven did for each additional
module (note that If we got rid of all the shading that we do, they would be
extremely fast).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 107205)
Time Spent: 9h 50m (was: 9h 40m)
> [SQL] Investigate JDBC interface for Beam SQL
> ---------------------------------------------
>
> Key: BEAM-3773
> URL: https://issues.apache.org/jira/browse/BEAM-3773
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> JDBC allows integration with a lot of third-party tools, e.g
> [Zeppelin|https://zeppelin.apache.org/docs/0.7.0/manual/interpreters.html],
> [sqlline|https://github.com/julianhyde/sqlline]. We should look into how
> feasible it is to implement a JDBC interface for Beam SQL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
