[ 
https://issues.apache.org/jira/browse/BEAM-4283?focusedWorklogId=107609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107609
 ]

ASF GitHub Bot logged work on BEAM-4283:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/May/18 08:40
            Start Date: 31/May/18 08:40
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on a change in pull request 
#5464: [BEAM-4283] Write Nexmark execution times to bigquery
URL: https://github.com/apache/beam/pull/5464#discussion_r192022213
 
 

 ##########
 File path: 
sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
 ##########
 @@ -146,13 +164,77 @@ private void appendPerf(
   private static final String LINE =
       
"==========================================================================================";
 
-  /**
-   * Print summary  of {@code actual} vs (if non-null) {@code baseline}.
-   */
+  /** Send {@code nexmarkPerf} to BigQuery. */
+  @VisibleForTesting
+  static void writeQueryPerftoBigQuery(
 
 Review comment:
   Can we perform this write using a Beam pipeline that uses DirectRunner and 
BigQuery sink instead of using BigQueryService class ? I think you should use 
either that or use a BigQuery client library directly instead of using the 
intermediate "BigQueryService" class in Beam which is not intended to be a 
public utility.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 107609)
    Time Spent: 1h  (was: 50m)

> Export nexmark execution times to bigQuery
> ------------------------------------------
>
>                 Key: BEAM-4283
>                 URL: https://issues.apache.org/jira/browse/BEAM-4283
>             Project: Beam
>          Issue Type: Sub-task
>          Components: examples-nexmark
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Nexmark only outputs the results collection to bigQuery and prints in the 
> console the execution times. To supervise Nexmark execution times, we need to 
> store them as well per runner/query/mode



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to