[
https://issues.apache.org/jira/browse/BEAM-4283?focusedWorklogId=107622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107622
]
ASF GitHub Bot logged work on BEAM-4283:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/18 09:42
Start Date: 31/May/18 09:42
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #5464:
[BEAM-4283] Write Nexmark execution times to bigquery
URL: https://github.com/apache/beam/pull/5464#discussion_r192043662
##########
File path:
sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -146,13 +164,77 @@ private void appendPerf(
private static final String LINE =
"==========================================================================================";
- /**
- * Print summary of {@code actual} vs (if non-null) {@code baseline}.
- */
+ /** Send {@code nexmarkPerf} to BigQuery. */
+ @VisibleForTesting
+ static void writeQueryPerftoBigQuery(
Review comment:
For your 2 questions:
1. No, here we output to BigQuery only the response time of the pipeline so
it needs to be finished.
2. What you suggest (bigquery client) is what I did at first and I asked you
how I can unit test it and you answered that I should use FakeBigQueryServices.
But to use FakeBigQueryServices I needed to refactor everything to use
FakeBigQueryServices's super class (BigQueryServices)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 107622)
Time Spent: 1.5h (was: 1h 20m)
> Export nexmark execution times to bigQuery
> ------------------------------------------
>
> Key: BEAM-4283
> URL: https://issues.apache.org/jira/browse/BEAM-4283
> Project: Beam
> Issue Type: Sub-task
> Components: examples-nexmark
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Nexmark only outputs the results collection to bigQuery and prints in the
> console the execution times. To supervise Nexmark execution times, we need to
> store them as well per runner/query/mode
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
