[
https://issues.apache.org/jira/browse/BEAM-4313?focusedWorklogId=109864&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-109864
]
ASF GitHub Bot logged work on BEAM-4313:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/18 21:28
Start Date: 07/Jun/18 21:28
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #5540:
[BEAM-4313] Fix and enforce FindBugs and ErrorProne violations in Dataflow
Runner
URL: https://github.com/apache/beam/pull/5540#discussion_r193894420
##########
File path: sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml
##########
@@ -139,6 +139,33 @@
<!-- Takes ownership of input buffer -->
</Match>
+ <Match>
+ <Class name="org.apache.beam.runners.dataflow.util.MonitoringUtilTest" />
+ <Field name="thrown" />
+ <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" />
Review comment:
Can you elaborate on what has changed? Here's my understanding of things:
* FindBugs uses a
[`@SuppressFBWarnings`](http://findbugs.sourceforge.net/api/edu/umd/cs/findbugs/annotations/SuppressFBWarnings.html)
annotation for inline suppressions.
* There is also a
[`@edu.umd.cs.findbugs.annotations.SuppressWarnings`](http://findbugs.sourceforge.net/api/edu/umd/cs/findbugs/annotations/SuppressWarnings.html),
but it is marked as deprecated in favor of `@SuppressFBWarnings` since it
clashes the other `@SuppressWarnings` annotation
* We [previously removed
references](https://github.com/apache/beam/pull/1401) to `@SuppressFBWarnings`
because it is only available via
[`com.google.code.findbugs:annotations](https://mvnrepository.com/artifact/com.google.code.findbugs/annotations)
under LGPL.
Also it seems the general direction is to stop supporting FindBugs in favor
of ErrorProne / SpotBugs. So it doesn't seem worth much to invest in migrating
the suppressions file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 109864)
Time Spent: 2h 10m (was: 2h)
> Enforce ErrorProne analysis in Dataflow runner project
> ------------------------------------------------------
>
> Key: BEAM-4313
> URL: https://issues.apache.org/jira/browse/BEAM-4313
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Minor
> Labels: errorprone, starter
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-runners-google-cloud-dataflow-java}}. Additional context discussed on
> the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-runners-google-cloud-dataflow-java:assemble}}
> # Fix each ErrorProne warning from the {{runners/google-cloud-dataflow-java}}
> project.
> # In {{runners/google-cloud-dataflow-java/build.gradle}}, add
> {{failOnWarning: true}} to the call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
