ASF GitHub Bot logged work on BEAM-4313:

                Author: ASF GitHub Bot
            Created on: 12/Jun/18 19:09
            Start Date: 12/Jun/18 19:09
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on a change in pull request 
#5540: [BEAM-4313] Fix and enforce FindBugs and ErrorProne violations in 
Dataflow Runner
URL: https://github.com/apache/beam/pull/5540#discussion_r194856069

 File path: sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml
 @@ -139,6 +139,33 @@
     <!-- Takes ownership of input buffer -->
+  <Match>
+    <Class name="org.apache.beam.runners.dataflow.util.MonitoringUtilTest" />
+    <Field name="thrown" />
 Review comment:
   There's actually an ASF licensed compatible annotation package which we 
depend on already. But I'd rather just get this in as-is. The XML is fine too, 
though then we will just delete it I guess and might miss some places where the 
new tool isn't protecting us.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 111225)
    Time Spent: 2h 40m  (was: 2.5h)

> Enforce ErrorProne analysis in Dataflow runner project
> ------------------------------------------------------
>                 Key: BEAM-4313
>                 URL: https://issues.apache.org/jira/browse/BEAM-4313
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow
>            Reporter: Scott Wegner
>            Assignee: Scott Wegner
>            Priority: Minor
>              Labels: errorprone, starter
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
> Java ErrorProne static analysis was [recently 
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build 
> process, but only as warnings. ErrorProne errors are generally useful and 
> easy to fix. Some work was done to [make sdks-java-core 
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add 
> enforcement. This task is clean ErrorProne warnings and add enforcement in 
> {{beam-runners-google-cloud-dataflow-java}}. Additional context discussed on 
> the [dev 
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution 
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development 
> environment.
> # Run the following command to compile and run ErrorProne analysis on the 
> project: {{./gradlew :beam-runners-google-cloud-dataflow-java:assemble}}
> # Fix each ErrorProne warning from the {{runners/google-cloud-dataflow-java}} 
> project.
> # In {{runners/google-cloud-dataflow-java/build.gradle}}, add 
> {{failOnWarning: true}} to the call the {{applyJavaNature()}} 
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach 
> out|https://beam.apache.org/community/contact-us/] with questions or code 
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com

This message was sent by Atlassian JIRA

Reply via email to