[
https://issues.apache.org/jira/browse/BEAM-4365?focusedWorklogId=110191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110191
]
ASF GitHub Bot logged work on BEAM-4365:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/18 17:54
Start Date: 08/Jun/18 17:54
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #5433:
[BEAM-4365] Make BeamSqlExpression for operators, use it for string operators
URL: https://github.com/apache/beam/pull/5433
Previously, every operator had its own expression class. In addition to
boilerplate, this meant that each operator separately controlled the SQL
calling convention, explicitly calling to evaluate their arguments. I think it
is safe to have inconsistencies because the expression language is pure and
terminating, but still it should be centralized.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 110191)
Time Spent: 1h 20m (was: 1h 10m)
> SQL operator argument evaluation should have one place where it is managed
> --------------------------------------------------------------------------
>
> Key: BEAM-4365
> URL: https://issues.apache.org/jira/browse/BEAM-4365
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The way Beam SQL is factored, each operator has to explicitly ask its
> argument to be evaluated. This should be handled generically at a higher
> level. Since the language is pure and terminating, it is fine for them to
> vary, but given the simplicity of the expression language it makes sense to
> use simple call-by-value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
