[
https://issues.apache.org/jira/browse/BEAM-4365?focusedWorklogId=110289&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110289
]
ASF GitHub Bot logged work on BEAM-4365:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/18 21:33
Start Date: 08/Jun/18 21:33
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5433: [BEAM-4365] Make BeamSqlExpression for operators, use it for string
operators
URL: https://github.com/apache/beam/pull/5433#discussion_r194186790
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/integrationtest/BeamSqlStringFunctionsIntegrationTest.java
##########
@@ -31,8 +31,8 @@ public void testStringFunctions() throws Exception {
.addExpr("CHARACTER_LENGTH('hello')", 5)
.addExpr("UPPER('hello')", "HELLO")
.addExpr("LOWER('HELLO')", "hello")
- .addExpr("POSITION('world' IN 'helloworld')", 5)
- .addExpr("POSITION('world' IN 'helloworldworld' FROM 7)", 10)
+ .addExpr("POSITION('world' IN 'helloworld')", 6)
+ .addExpr("POSITION('world' IN 'helloworldworld' FROM 7)", 11)
Review comment:
Pretty much every SQL is 1 based.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 110289)
Time Spent: 2.5h (was: 2h 20m)
> SQL operator argument evaluation should have one place where it is managed
> --------------------------------------------------------------------------
>
> Key: BEAM-4365
> URL: https://issues.apache.org/jira/browse/BEAM-4365
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The way Beam SQL is factored, each operator has to explicitly ask its
> argument to be evaluated. This should be handled generically at a higher
> level. Since the language is pure and terminating, it is fine for them to
> vary, but given the simplicity of the expression language it makes sense to
> use simple call-by-value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
