[
https://issues.apache.org/jira/browse/BEAM-4549?focusedWorklogId=111619&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111619
]
ASF GitHub Bot logged work on BEAM-4549:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/18 19:20
Start Date: 13/Jun/18 19:20
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#5623: [BEAM-4549] Use per-pipeline unique ids for side inputs in DataflowRunner
URL: https://github.com/apache/beam/pull/5623#discussion_r195205537
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -590,7 +593,7 @@ def run_ParDo(self, transform_node):
for ix, side_pval in enumerate(transform_node.side_inputs):
assert isinstance(side_pval, AsSideInput)
step_name = 'SideInput-' + self._get_unique_step_name()
- si_label = 'side%d' % ix
+ si_label = 'side-%s-%d' % (pardo_step_name, ix)
Review comment:
At least the existing behavior is that each side input gets a unique step
name distinct from the ParDo's step name. I think we should keep that for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 111619)
Time Spent: 1h (was: 50m)
> Streaming pipelines with multiple side inputs fail on DataflowRunner
> --------------------------------------------------------------------
>
> Key: BEAM-4549
> URL: https://issues.apache.org/jira/browse/BEAM-4549
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Charles Chen
> Assignee: Charles Chen
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Streaming pipelines with multiple side inputs currently fail on
> DataflowRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
