[
https://issues.apache.org/jira/browse/BEAM-4549?focusedWorklogId=112168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112168
]
ASF GitHub Bot logged work on BEAM-4549:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/18 04:39
Start Date: 15/Jun/18 04:39
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #5655:
[BEAM-4549] Fix side inputs for streaming pipelines on Dataflow
URL: https://github.com/apache/beam/pull/5655#discussion_r195631783
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -891,8 +892,9 @@ def from_runner_api_parameter(pardo_payload, context):
# This is an ordered list stored as a dict (see the comments in
# to_runner_api_parameter above).
indexed_side_inputs = [
- (int(ix[4:]), pvalue.AsSideInput.from_runner_api(si, context))
- for ix, si in pardo_payload.side_inputs.items()]
+ (int(re.match('side([0-9]+)(-.*)?$', tag).group(1)),
Review comment:
why (-.*)? instead of -.*?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 112168)
Time Spent: 2h 40m (was: 2.5h)
> Streaming pipelines with multiple side inputs fail on DataflowRunner
> --------------------------------------------------------------------
>
> Key: BEAM-4549
> URL: https://issues.apache.org/jira/browse/BEAM-4549
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Charles Chen
> Assignee: Charles Chen
> Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Streaming pipelines with multiple side inputs currently fail on
> DataflowRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
