[
https://issues.apache.org/jira/browse/BEAM-4555?focusedWorklogId=111641&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111641
]
ASF GitHub Bot logged work on BEAM-4555:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/18 20:36
Start Date: 13/Jun/18 20:36
Worklog Time Spent: 10m
Work Description: swegner opened a new pull request #5637: [DO NOT MERGE]
Test change to validate [BEAM-4555]
URL: https://github.com/apache/beam/pull/5637
In BEAM-4445 we changed pre-commit triggering on PR's to only run when
afffected file paths were changed. However as a side-effect, it is no longer
possible to use trigger phrases to manually run pre-commits if include path
files are not changed.
This PR is just a test to repro this is broken.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 111641)
Time Spent: 10m
Remaining Estimate: 0h
> Pre-commit file include triggering breaks phrase triggering
> -----------------------------------------------------------
>
> Key: BEAM-4555
> URL: https://issues.apache.org/jira/browse/BEAM-4555
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In BEAM-4445 we changed pre-commit triggering on PR's to only run when
> afffected file paths were changed. However as a side-effect, it is no longer
> possible to use trigger phrases to manually run pre-commits if include path
> files are not changed.
> This ability to run a pre-commit even if files are not changed is useful to
> check the stability of the codebase before submitting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
