[ https://issues.apache.org/jira/browse/BEAM-4555?focusedWorklogId=111658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111658 ]
ASF GitHub Bot logged work on BEAM-4555: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Jun/18 21:03 Start Date: 13/Jun/18 21:03 Worklog Time Spent: 10m Work Description: swegner commented on issue #5638: [BEAM-4555] Revert pull request pre-commit triggering URL: https://github.com/apache/beam/pull/5638#issuecomment-397086166 Repro: #5637 R: @jbonofre CC: @udim I am running the Seed job on this PR which temporarily unblocks us. The Seed Job will run on master on a schedule and overwrite this run. So until this gets merged we can continue to re-trigger the Seed job here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 111658) Time Spent: 1h 50m (was: 1h 40m) > Pre-commit file include triggering breaks phrase triggering > ----------------------------------------------------------- > > Key: BEAM-4555 > URL: https://issues.apache.org/jira/browse/BEAM-4555 > Project: Beam > Issue Type: Bug > Components: testing > Reporter: Scott Wegner > Assignee: Scott Wegner > Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > In BEAM-4445 we changed pre-commit triggering on PR's to only run when > afffected file paths were changed. However as a side-effect, it is no longer > possible to use trigger phrases to manually run pre-commits if include path > files are not changed. > This ability to run a pre-commit even if files are not changed is useful to > check the stability of the codebase before submitting. -- This message was sent by Atlassian JIRA (v7.6.3#76005)