[
https://issues.apache.org/jira/browse/BEAM-4130?focusedWorklogId=111633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111633
]
ASF GitHub Bot logged work on BEAM-4130:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/18 20:20
Start Date: 13/Jun/18 20:20
Worklog Time Spent: 10m
Work Description: axelmagn commented on a change in pull request #5493:
[BEAM-4130] Add job submission capabilities to Flink runner.
URL: https://github.com/apache/beam/pull/5493#discussion_r195221468
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/jobsubmission/InMemoryJobService.java
##########
@@ -60,17 +60,28 @@
public static InMemoryJobService create(
Endpoints.ApiServiceDescriptor stagingServiceDescriptor, JobInvoker
invoker) {
- return new InMemoryJobService(stagingServiceDescriptor, invoker);
+ return new InMemoryJobService(stagingServiceDescriptor, (String session)
-> "token", invoker);
+ }
+
+ public static InMemoryJobService create(
+ Endpoints.ApiServiceDescriptor stagingServiceDescriptor,
+ Function<String, String> stagingServiceTokenProvider,
Review comment:
maybe document that this function expects a preparation ID as input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 111633)
Time Spent: 20m (was: 10m)
> Portable Flink runner JobService entry point in a Docker container
> ------------------------------------------------------------------
>
> Key: BEAM-4130
> URL: https://issues.apache.org/jira/browse/BEAM-4130
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The portable Flink runner exists as a Job Service that runs somewhere. We
> need a main entry point that itself spins up the job service (and artifact
> staging service). The main program itself should be packaged into an uberjar
> such that it can be run locally or submitted to a Flink deployment via `flink
> run`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
