[
https://issues.apache.org/jira/browse/BEAM-4130?focusedWorklogId=111702&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111702
]
ASF GitHub Bot logged work on BEAM-4130:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/18 22:25
Start Date: 13/Jun/18 22:25
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #5493:
[BEAM-4130] Add job submission capabilities to Flink runner.
URL: https://github.com/apache/beam/pull/5493#discussion_r195254764
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/artifact/BeamFileSystemArtifactSourceTest.java
##########
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.fnexecution.artifact;
+
+import static org.hamcrest.Matchers.containsInAnyOrder;
+
+import com.google.protobuf.ByteString;
+import io.grpc.stub.StreamObserver;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
+import org.apache.beam.model.jobmanagement.v1.ArtifactApi;
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+/**
+ * Tests for BeamFileSystemArtifactSource.
+ */
+@RunWith(JUnit4.class) public class BeamFileSystemArtifactSourceTest {
+
+ BeamFileSystemArtifactStagingService stagingService = new
BeamFileSystemArtifactStagingService();
+
+ @Rule public TemporaryFolder stagingDir = new TemporaryFolder();
+
+ @Test public void testStagingService() throws Exception {
+ String stagingSession = "stagingSession";
+ String stagingSessionToken = BeamFileSystemArtifactStagingService
+ .generateStagingSessionToken(stagingSession,
stagingDir.newFolder().getPath());
+ List<ArtifactApi.ArtifactMetadata> metadata = new ArrayList<>();
+
+
metadata.add(ArtifactApi.ArtifactMetadata.newBuilder().setName("file1").build());
+ putArtifactContents(stagingSessionToken, "first", "file1");
+
+
metadata.add(ArtifactApi.ArtifactMetadata.newBuilder().setName("file2").build());
+ putArtifactContents(stagingSessionToken, "second", "file2");
+
+ String stagingToken = commitManifest(stagingSessionToken, metadata);
+
+ BeamFileSystemArtifactSource artifactSource = new
BeamFileSystemArtifactSource(stagingToken);
+ Assert.assertEquals("first", getArtifactContents(artifactSource, "file1"));
+ Assert.assertEquals("second", getArtifactContents(artifactSource,
"file2"));
+ Assert.assertThat(artifactSource.getManifest().getArtifactList(),
+ containsInAnyOrder(metadata.toArray(new
ArtifactApi.ArtifactMetadata[0])));
+ }
+
+ private String commitManifest(String stagingSessionToken,
+ List<ArtifactApi.ArtifactMetadata> artifacts) {
+ String[] stagingTokenHolder = new String[1];
+ stagingService.commitManifest(
+
ArtifactApi.CommitManifestRequest.newBuilder().setStagingSessionToken(stagingSessionToken)
+
.setManifest(ArtifactApi.Manifest.newBuilder().addAllArtifact(artifacts)).build(),
+ new StreamObserver<ArtifactApi.CommitManifestResponse>() {
+
+ @Override public void onNext(ArtifactApi.CommitManifestResponse
commitManifestResponse) {
+ stagingTokenHolder[0] = commitManifestResponse.getRetrievalToken();
+ }
+
+ @Override public void onError(Throwable throwable) {
+ throw new RuntimeException(throwable);
+ }
+
+ @Override public void onCompleted() {
+ }
+ });
+
+ return stagingTokenHolder[0];
+ }
+
+ private void putArtifactContents(String stagingSessionToken, String
contents, String name) {
+ StreamObserver<ArtifactApi.PutArtifactRequest> outputStreamObserver =
stagingService
+ .putArtifact(new StreamObserver<ArtifactApi.PutArtifactResponse>() {
+
+ @Override public void onNext(ArtifactApi.PutArtifactResponse
putArtifactResponse) {
+ }
+
+ @Override public void onError(Throwable throwable) {
+ throw new RuntimeException(throwable);
+ }
+
+ @Override public void onCompleted() {
+ }
+ });
+
+
outputStreamObserver.onNext(ArtifactApi.PutArtifactRequest.newBuilder().setMetadata(
+ ArtifactApi.PutArtifactMetadata.newBuilder()
+
.setMetadata(ArtifactApi.ArtifactMetadata.newBuilder().setName(name).build())
+ .setStagingSessionToken(stagingSessionToken)).build());
+
outputStreamObserver.onNext(ArtifactApi.PutArtifactRequest.newBuilder().setData(
+ ArtifactApi.ArtifactChunk.newBuilder()
+ .setData(ByteString.copyFrom(contents,
StandardCharsets.UTF_8))).build());
+ outputStreamObserver.onCompleted();
+ }
+
+ private String getArtifactContents(ArtifactSource artifactSource, String
name)
+ throws IOException {
+ StringBuilder contents = new StringBuilder();
+ artifactSource.getArtifact(name, new
StreamObserver<ArtifactApi.ArtifactChunk>() {
+
+ @Override public void onNext(ArtifactApi.ArtifactChunk artifactChunk) {
+
contents.append(artifactChunk.getData().toString(StandardCharsets.UTF_8));
+ }
+
+ @Override public void onError(Throwable throwable) {
+ throw new RuntimeException(throwable);
+ }
+
+ @Override public void onCompleted() {
+ }
+ });
+ return contents.toString();
Review comment:
We should wait for the call to finish before returning the contents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 111702)
Time Spent: 2.5h (was: 2h 20m)
> Portable Flink runner JobService entry point in a Docker container
> ------------------------------------------------------------------
>
> Key: BEAM-4130
> URL: https://issues.apache.org/jira/browse/BEAM-4130
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Minor
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The portable Flink runner exists as a Job Service that runs somewhere. We
> need a main entry point that itself spins up the job service (and artifact
> staging service). The main program itself should be packaged into an uberjar
> such that it can be run locally or submitted to a Flink deployment via `flink
> run`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
