[
https://issues.apache.org/jira/browse/BEAM-4130?focusedWorklogId=111704&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111704
]
ASF GitHub Bot logged work on BEAM-4130:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/18 22:25
Start Date: 13/Jun/18 22:25
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #5493:
[BEAM-4130] Add job submission capabilities to Flink runner.
URL: https://github.com/apache/beam/pull/5493#discussion_r195251040
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
##########
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.flink;
+
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import java.io.IOException;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ThreadFactory;
+import org.apache.beam.model.pipeline.v1.Endpoints;
+import org.apache.beam.runners.fnexecution.GrpcFnServer;
+import org.apache.beam.runners.fnexecution.ServerFactory;
+import
org.apache.beam.runners.fnexecution.artifact.BeamFileSystemArtifactStagingService;
+import org.apache.beam.runners.fnexecution.jobsubmission.InMemoryJobService;
+import org.apache.beam.runners.fnexecution.jobsubmission.JobInvoker;
+import org.kohsuke.args4j.CmdLineException;
+import org.kohsuke.args4j.CmdLineParser;
+import org.kohsuke.args4j.Option;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+/** Driver program that starts a job server. */
+public class FlinkJobServerDriver implements Runnable {
+ private static final Logger LOG =
LoggerFactory.getLogger(FlinkJobServerDriver.class);
+
+ private static class ServerConfiguration {
+ @Option(
+ name = "--job-host",
+ required = true,
+ usage = "The job server host string"
+ )
+ private String host = "";
+
+ @Option(
+ name = "--artifacts-dir",
+ usage = "The location to store staged artifact files"
+ )
+ private String artifactStagingPath = "/tmp/beam-artifact-staging";
+ }
+
+ public static void main(String[] args) {
+ ServerConfiguration configuration = new ServerConfiguration();
+ CmdLineParser parser = new CmdLineParser(configuration);
+ try {
+ parser.parseArgument(args);
+ } catch (CmdLineException e) {
+ e.printStackTrace(System.err);
+ printUsage(parser);
+ return;
+ }
+ FlinkJobServerDriver driver = fromConfig(configuration);
+ driver.run();
+ }
+
+ private static void printUsage(CmdLineParser parser) {
+ System.err.println(
+ String.format(
+ "Usage: java %s arguments...",
FlinkJobServerDriver.class.getSimpleName()));
+ parser.printUsage(System.err);
+ System.err.println();
+ }
+
+ public static FlinkJobServerDriver fromConfig(ServerConfiguration
configuration) {
+ ThreadFactory threadFactory =
+ new
ThreadFactoryBuilder().setNameFormat("flink-runner-job-server").setDaemon(true).build();
+ ListeningExecutorService executor =
+
MoreExecutors.listeningDecorator(Executors.newCachedThreadPool(threadFactory));
+ ServerFactory serverFactory = ServerFactory.createDefault();
+ return create(configuration, executor, serverFactory);
+ }
+
+ public static FlinkJobServerDriver create(
+ ServerConfiguration configuration,
+ ListeningExecutorService executor,
+ ServerFactory serverFactory) {
+ return new FlinkJobServerDriver(configuration, executor, serverFactory);
+ }
+
+ private final ListeningExecutorService executor;
Review comment:
We should move these variables to the top.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 111704)
> Portable Flink runner JobService entry point in a Docker container
> ------------------------------------------------------------------
>
> Key: BEAM-4130
> URL: https://issues.apache.org/jira/browse/BEAM-4130
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Minor
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The portable Flink runner exists as a Job Service that runs somewhere. We
> need a main entry point that itself spins up the job service (and artifact
> staging service). The main program itself should be packaged into an uberjar
> such that it can be run locally or submitted to a Flink deployment via `flink
> run`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
