[ 
https://issues.apache.org/jira/browse/BEAM-4555?focusedWorklogId=113556&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113556
 ]

ASF GitHub Bot logged work on BEAM-4555:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jun/18 05:02
            Start Date: 20/Jun/18 05:02
    Worklog Time Spent: 10m 
      Work Description: swegner closed pull request #5637: [DO NOT MERGE] Test 
change to validate [BEAM-4555]
URL: https://github.com/apache/beam/pull/5637
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/go/build.gradle b/sdks/go/build.gradle
index 7a3a95792d9..99a4fec7082 100644
--- a/sdks/go/build.gradle
+++ b/sdks/go/build.gradle
@@ -19,6 +19,7 @@
 apply from: project(":").file("build_rules.gradle")
 applyGoNature()
 
+
 description = "Apache Beam :: SDKs :: Go"
 
 golang {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 113556)
    Time Spent: 2h 10m  (was: 2h)

> Pre-commit file include triggering breaks phrase triggering
> -----------------------------------------------------------
>
>                 Key: BEAM-4555
>                 URL: https://issues.apache.org/jira/browse/BEAM-4555
>             Project: Beam
>          Issue Type: Bug
>          Components: testing
>            Reporter: Scott Wegner
>            Assignee: Scott Wegner
>            Priority: Major
>             Fix For: 2.6.0
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> In BEAM-4445 we changed pre-commit triggering on PR's to only run when 
> afffected file paths were changed. However as a side-effect, it is no longer 
> possible to use trigger phrases to manually run pre-commits if include path 
> files are not changed.
> This ability to run a pre-commit even if files are not changed is useful to 
> check the stability of the codebase before submitting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to