[
https://issues.apache.org/jira/browse/BEAM-4584?focusedWorklogId=114521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-114521
]
ASF GitHub Bot logged work on BEAM-4584:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/18 22:21
Start Date: 21/Jun/18 22:21
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #5730:
[BEAM-4584] Remove build_rules.gradle
URL: https://github.com/apache/beam/pull/5730
This followup removes `build_rules.gradle` which is just an unneeded proxy
for `BeamModulePlugin`
(I didn't do it in the prior PR because I thought it would be more difficult
than it was)
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 114521)
Time Spent: 5h (was: 4h 50m)
> Use a "binary plugin" in buildSrc instead of "script plugin" in
> build_rules.gradle
> ----------------------------------------------------------------------------------
>
> Key: BEAM-4584
> URL: https://issues.apache.org/jira/browse/BEAM-4584
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> This is a best practice recommended by the Gradle documentation. It is
> expected to speed things up, and makes dependency management and testing
> slightly better.
> In terms of code, it is not much different, though some things that were
> previously implicit in the top-level groovy DSL will need to be made explicit
> in the plugin definition.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
