[
https://issues.apache.org/jira/browse/BEAM-4584?focusedWorklogId=114834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-114834
]
ASF GitHub Bot logged work on BEAM-4584:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/18 16:47
Start Date: 22/Jun/18 16:47
Worklog Time Spent: 10m
Work Description: alanmyrvold edited a comment on issue #5683:
[BEAM-4584] Migrate build_rules.gradle to buildSrc plugin
URL: https://github.com/apache/beam/pull/5683#issuecomment-399504917
I now see errors like:
A problem occurred evaluating project ':beam-sdks-go-container'.
> No such property: rootProject for class:
org.apache.beam.gradle.BeamModulePlugin
A problem occurred evaluating project ':beam-sdks-python-container'.
> No such property: rootProject for class:
org.apache.beam.gradle.BeamModulePlugin
This is causing failures in
https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild and
https://builds.apache.org/job/beam_PostCommit_Py_ValCont
@kennknowles Can you take a look?
https://issues.apache.org/jira/browse/BEAM-4623
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 114834)
Time Spent: 6h (was: 5h 50m)
> Use a "binary plugin" in buildSrc instead of "script plugin" in
> build_rules.gradle
> ----------------------------------------------------------------------------------
>
> Key: BEAM-4584
> URL: https://issues.apache.org/jira/browse/BEAM-4584
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> This is a best practice recommended by the Gradle documentation. It is
> expected to speed things up, and makes dependency management and testing
> slightly better.
> In terms of code, it is not much different, though some things that were
> previously implicit in the top-level groovy DSL will need to be made explicit
> in the plugin definition.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
