[
https://issues.apache.org/jira/browse/BEAM-4661?focusedWorklogId=116565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116565
]
ASF GitHub Bot logged work on BEAM-4661:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/18 20:09
Start Date: 27/Jun/18 20:09
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#5789: [BEAM-4661] Define well known timer coder URN.
URL: https://github.com/apache/beam/pull/5789#discussion_r198624910
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -575,13 +575,27 @@ message StandardCoders {
// Components: Coder for a single element.
ITERABLE = 3 [(beam_urn) = "beam:coder:iterable:v1"];
- // Components: None
- TIMESTAMP = 4 [(beam_urn) = "beam:coder:timestamp:v1"];
+ // Encodes a timer containing a timestamp and a user specified payload.
+ // The encoding is represented as: timestamp payload
+ // timestamp - an 8 byte integer shifted by -9223372036854775808 encoded
Review comment:
Nit: Can you clarify the language with "shifted by"? At first, I thought it
means that to encode any integer, you add `-9223372036854775808`, but that
isn't the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 116565)
Time Spent: 40m (was: 0.5h)
> Define well known timer URN
> ---------------------------
>
> Key: BEAM-4661
> URL: https://issues.apache.org/jira/browse/BEAM-4661
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
