[
https://issues.apache.org/jira/browse/BEAM-4661?focusedWorklogId=116603&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116603
]
ASF GitHub Bot logged work on BEAM-4661:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/18 21:02
Start Date: 27/Jun/18 21:02
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5789: [BEAM-4661] Define
well known timer coder URN.
URL: https://github.com/apache/beam/pull/5789
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/model/pipeline/src/main/proto/beam_runner_api.proto
b/model/pipeline/src/main/proto/beam_runner_api.proto
index 8be95dbe640..16cb4e75dbb 100644
--- a/model/pipeline/src/main/proto/beam_runner_api.proto
+++ b/model/pipeline/src/main/proto/beam_runner_api.proto
@@ -575,13 +575,29 @@ message StandardCoders {
// Components: Coder for a single element.
ITERABLE = 3 [(beam_urn) = "beam:coder:iterable:v1"];
- // Components: None
- TIMESTAMP = 4 [(beam_urn) = "beam:coder:timestamp:v1"];
+ // Encodes a timer containing a timestamp and a user specified payload.
+ // The encoding is represented as: timestamp payload
+ // timestamp - a big endian 8 byte integer representing
millis-since-epoch.
+ // The encoded representation is shifted so that the byte
representation of
+ // negative values are lexicographically ordered before the byte
representation
+ // of positive values. This is typically done by subtracting
-9223372036854775808
+ // from the value and encoding it as a signed big endian integer.
Example values:
+ //
+ // -9223372036854775808: 00 00 00 00 00 00 00 00
+ // -255: 7F FF FF FF FF FF FF 01
+ // -1: 7F FF FF FF FF FF FF FF
+ // 0: 80 00 00 00 00 00 00 00
+ // 1: 80 00 00 00 00 00 00 01
+ // 256: 80 00 00 00 00 00 01 00
+ // 9223372036854775807: FF FF FF FF FF FF FF FF
+ // payload - user defined data, uses the component coder
+ // Components: Coder for the payload.
+ TIMER = 4 [(beam_urn) = "beam:coder:timer:v1"];
+
/*
- * The following coders are typically not specified by manually by the
user,
+ * The following coders are typically not specified manually by the user,
* but are used at runtime and must be supported by every SDK.
*/
-
// Components: None
INTERVAL_WINDOW = 5 [(beam_urn) = "beam:coder:interval_window:v1"];
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 116603)
Time Spent: 1h 10m (was: 1h)
> Define well known timer URN
> ---------------------------
>
> Key: BEAM-4661
> URL: https://issues.apache.org/jira/browse/BEAM-4661
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
