[
https://issues.apache.org/jira/browse/BEAM-4000?focusedWorklogId=117256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117256
]
ASF GitHub Bot logged work on BEAM-4000:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/18 07:44
Start Date: 29/Jun/18 07:44
Worklog Time Spent: 10m
Work Description: superbobry commented on a change in pull request #5715:
[BEAM-4000] Futurize io subpackage
URL: https://github.com/apache/beam/pull/5715#discussion_r199076933
##########
File path: sdks/python/apache_beam/io/filebasedsource.py
##########
@@ -235,11 +241,11 @@ class _SingleFileSource(iobase.BoundedSource):
def __init__(self, file_based_source, file_name, start_offset, stop_offset,
min_bundle_size=0, splittable=True):
- if not isinstance(start_offset, integer_types):
+ if not isinstance(start_offset, (int, long)):
Review comment:
If you import from `past` you can replace this with just `int`.
See http://python-future.org/compatible_idioms.html#long-integers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 117256)
Time Spent: 1h 10m (was: 1h)
> Futurize and fix python 2 compatibility for io subpackage
> ---------------------------------------------------------
>
> Key: BEAM-4000
> URL: https://issues.apache.org/jira/browse/BEAM-4000
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
