[ 
https://issues.apache.org/jira/browse/BEAM-4000?focusedWorklogId=118499&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118499
 ]

ASF GitHub Bot logged work on BEAM-4000:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jul/18 00:05
            Start Date: 03/Jul/18 00:05
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on a change in pull request 
#5715: [BEAM-4000] Futurize io subpackage
URL: https://github.com/apache/beam/pull/5715#discussion_r198317488
 
 

 ##########
 File path: sdks/python/apache_beam/io/filesystem.py
 ##########
 @@ -22,30 +22,42 @@
 """
 
 from __future__ import absolute_import
+from __future__ import division
 
 import abc
 import bz2
-import cStringIO
 import fnmatch
 import logging
 import os
 import posixpath
 import re
 import time
 import zlib
+from builtins import object
+from builtins import zip
+from io import BytesIO
 
-from six import integer_types
-from six import string_types
+from future import standard_library
+from future.utils import with_metaclass
 
 from apache_beam.utils.plugin import BeamPlugin
 
+standard_library.install_aliases()
 
 Review comment:
   Should we do this before `import io`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 118499)
    Time Spent: 1h 50m  (was: 1h 40m)

> Futurize and fix python 2 compatibility for io subpackage
> ---------------------------------------------------------
>
>                 Key: BEAM-4000
>                 URL: https://issues.apache.org/jira/browse/BEAM-4000
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Matthias Feys
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to