[
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=118173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118173
]
ASF GitHub Bot logged work on BEAM-4691:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/18 13:33
Start Date: 02/Jul/18 13:33
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #5831: [BEAM-4691]
(do-not-merge-yet!) Move perf tests to a separate directory and rename them
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-401805584
I did a small test in order to check if we can refactor the code this way
(split to directories, change to CamelCase). Below are some things I've found
out:
1. I am not sure if I can change the job_00_seed.groovy name. Jenkins didn't
change the glob pattern used to search for other job definitions when the name
was `Seed.groovy` (like it wasn't able to find the seed job when it's name
changed). Am I missing something here? Is path to seed job hardcoded in the
workspace/jenkins config (see: [the seed job run that cannot find jobs using
the old "job_"
pattern](https://builds.apache.org/view/A-D/view/Beam/job/beam_SeedJob/2133/console)).
2. I cannot import CommonProperties everywhere when the directory structure
is more than 1 level deep. This is described here:
[LINK](https://github.com/jenkinsci/job-dsl-plugin/wiki/Real-World-Examples#import-other-files-ie-with-class-definitions-into-your-script).
I will try to simplify the directory tree to be one level and check if it
works for our case.
3. I think we should split the CommonProperties file (former
common_job_properties). It's a "god object" to me and knows way too much.
Another good thing of having directories would be the possibility to hide
PreCommitBuilder in pre_commit directory (and so on) - so this is more than
just clean structure.
CC: @kennknowles @swegner request for comments :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118173)
Time Spent: 1h (was: 50m)
> Rename (and reorganize?) jenkins jobs
> -------------------------------------
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Łukasz Gajowy
> Assignee: Łukasz Gajowy
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Link to discussion:
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also
> place them in subdirectories instead of prefixing job names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
