[
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=118243&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118243
]
ASF GitHub Bot logged work on BEAM-4691:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/18 16:59
Start Date: 02/Jul/18 16:59
Worklog Time Spent: 10m
Work Description: swegner commented on issue #5831: [BEAM-4691]
(do-not-merge-yet!) Move perf tests to a separate directory and rename them
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-401869079
This is awesome, thanks for working on this. A couple thoughts:
> 1. I am not sure if I can change the job_00_seed.groovy name.
I suspect this is a bootstrapping problem. i.e., remember that when you run
the seed job, it's running the currently configured job from `master`, and
generating and publishing new job definitions from it. The currently published
job looks for `job_*`, so you might need a two-step process, i.e.:
1. Rename the files as planned, but also keep the original
`job_00_seed.groovy` version, and in that file add both glob patterns
2. Run that job to generate the new seed job definition
3. Once your change is merged to master and the new seed job is successfully
running, submit the change to remove the old seed job.
> 2. I cannot import CommonProperties everywhere when the directory
structure is more than 1 level deep.
Bummer. thanks for investigating this.
> 3. I think we should split the CommonProperties file (former
common_job_properties). It's a "god object" to me and knows way too much.
+:100: Any improvements we can make to this code is welcome. I recently
stumbled up this page on [Design patterns in
Groovy](http://groovy-lang.org/design-patterns.html)
CC @Ardagan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118243)
Time Spent: 1h 10m (was: 1h)
> Rename (and reorganize?) jenkins jobs
> -------------------------------------
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Łukasz Gajowy
> Assignee: Łukasz Gajowy
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Link to discussion:
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also
> place them in subdirectories instead of prefixing job names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
