[
https://issues.apache.org/jira/browse/BEAM-2732?focusedWorklogId=118880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118880
]
ASF GitHub Bot logged work on BEAM-2732:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/18 22:40
Start Date: 03/Jul/18 22:40
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #5356:
[BEAM-2732][BEAM-4028] Logging relies on StateSampler for context
URL: https://github.com/apache/beam/pull/5356#discussion_r199965280
##########
File path: sdks/python/apache_beam/runners/worker/logger.py
##########
@@ -34,7 +34,6 @@ class _PerThreadWorkerData(threading.local):
def __init__(self):
super(_PerThreadWorkerData, self).__init__()
- # TODO(robertwb): Consider starting with an initial (ignored) ~20 elements
Review comment:
The logging context will be removed once it's no longer useful (after it's
removed from Google code) so optimizations should not be considered anymore.
I'll remove it ASAP as part of BEAM-4728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118880)
Time Spent: 17h 10m (was: 17h)
> State tracking in Python is inefficient and has duplicated code
> ---------------------------------------------------------------
>
> Key: BEAM-2732
> URL: https://issues.apache.org/jira/browse/BEAM-2732
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 17h 10m
> Remaining Estimate: 0h
>
> e.g logging and metrics keep state separately. State tracking should be
> unified.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
