[
https://issues.apache.org/jira/browse/BEAM-2732?focusedWorklogId=118899&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118899
]
ASF GitHub Bot logged work on BEAM-2732:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/18 23:32
Start Date: 03/Jul/18 23:32
Worklog Time Spent: 10m
Work Description: pabloem edited a comment on issue #5356:
[BEAM-2732][BEAM-4028] Logging relies on StateSampler for context
URL: https://github.com/apache/beam/pull/5356#issuecomment-402320036
Results of the `map_fn_microbenchmark`. For some (i'd think
floating-point-related) reason, it gives per-element cost as zero, but if you
observe row-per-row, the cost with changes is slightly lower than the cost on
master.
On master:
```
1 element 0.798268 sec
1001 elements 1.01165 sec
2001 elements 1.05419 sec
3001 elements 1.1398 sec
4001 elements 1.37623 sec
5001 elements 1.47872 sec
6001 elements 1.68769 sec
7001 elements 1.68809 sec
8001 elements 1.8503 sec
9001 elements 2.0606 sec
Fixed cost 0.8104043092640963
Per-element 0.0
R^2 0.9845043457059202
```
With these changes:
```
1 element 0.796835 sec
1001 elements 0.952501 sec
2001 elements 1.01314 sec
3001 elements 1.17117 sec
4001 elements 1.31416 sec
5001 elements 1.3791 sec
6001 elements 1.54986 sec
7001 elements 1.68663 sec
8001 elements 1.71841 sec
9001 elements 1.93632 sec
Fixed cost 0.8011857992764676
Per-element 0.0
R^2 0.9922532858766798
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118899)
Time Spent: 18h (was: 17h 50m)
> State tracking in Python is inefficient and has duplicated code
> ---------------------------------------------------------------
>
> Key: BEAM-2732
> URL: https://issues.apache.org/jira/browse/BEAM-2732
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 18h
> Remaining Estimate: 0h
>
> e.g logging and metrics keep state separately. State tracking should be
> unified.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
